[webkit-reviews] review denied: [Bug 7868] REGRESSION: Extraneous
focus ring drawn at the end of the page : [Attachment 7275] patch 3
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Mar 24 08:19:11 PST 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7868: REGRESSION: Extraneous focus ring drawn at the end of the page
http://bugzilla.opendarwin.org/show_bug.cgi?id=7868
Attachment 7275: patch 3
http://bugzilla.opendarwin.org/attachment.cgi?id=7275&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. Almost ready to go.
Should use rect.isEmpty() rather than explicit checks for 0. (And if we were
keeping the checks for 0, need spaces around the "==".)
And we need the test in the patch as a layout test (even if only pixel test
results will show the focus ring).
Then I'll review+.
More information about the webkit-reviews
mailing list