[webkit-reviews] review cancelled: [Bug 7868] REGRESSION: Extraneous focus ring drawn at the end of the page : [Attachment 7239] patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Mar 24 01:56:00 PST 2006


Graham Dennis <Graham.Dennis at gmail.com> has cancelled Graham Dennis
<Graham.Dennis at gmail.com>'s request for review:
Bug 7868: REGRESSION: Extraneous focus ring drawn at the end of the page
http://bugzilla.opendarwin.org/show_bug.cgi?id=7868

Attachment 7239: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=7239&action=edit

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
The problem is caused by an anonymous element after the end of the <span>
element, but before the end of the </div> block. It is below where the span is,
and it has zero height. In this version of the patch, we just don't add in any
rectangles to the focus ring that have zero height or width.
I ran a pixel test layout check, and I found 33 cases with incorrect layout,
but they all fail here without the patch as well.

This is totally unrelated, but some of the test failures do concern me:
fast/AppleScript/date
fast/js/date-constructor
fast/parser/entities-in-xhtml



More information about the webkit-reviews mailing list