[webkit-reviews] review granted: [Bug 7882] Remove more DeprecatedString usage : [Attachment 7201] Remove more DeprecatedString

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7882: Remove more DeprecatedString usage
http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

Attachment 7201: Remove more DeprecatedString
http://bugzilla.opendarwin.org/attachment.cgi?id=7201&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
-    kdDebug( 6080 ) << "CSSParser::CSSParser this=" << this << endl;
+    kdDebug(6080) << "CSSParser::CSSParser this=" << this << endl;

-    kdDebug( 6080 ) << "CSS parse error " << str << endl;
+    kdDebug(6080) << "CSS parse error " << str << endl;

We don't even have kdDebug in our tree, so this should be removed rather than
reformatted.

There's a ton in this patch that has nothing to do with DeprecatedString.

-	     valid_primitive = ( validUnit( value, FLength, strict ) );
+	     valid_primitive = (validUnit(value, FLength, strict));

I suggest removing the parentheses altogether here.

+	     // qDebug(" new value: id=%d", id);

-//	kdDebug( 6080 ) << "  got style, variant and weight current=" <<
valueList->currentValue << endl;
+//	kdDebug(6080) << "  got style, variant and weight current=" <<
valueList->currentValue << endl;

-    // kdDebug( 6080 ) << "  got size" << endl;
+    // kdDebug(6080) << "  got size" << endl;

+	 //qDebug("value = %s, converted=%.2f", DeprecatedString((QChar *)t,
length).latin1(), yylval->val);

Lets remove commented-out debugging code too.