[webkit-reviews] review requested: [Bug 7904] Unnecessary layout after pre-paste test insertion : [Attachment 7226] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 22 01:14:39 PST 2006

Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 7904: Unnecessary layout after pre-paste test insertion

Attachment 7226: patch

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
I want the ReplacementFragment to be destroyed and the holder removed when the
paste is complete, so I made it a local variable inside doApply().  It was
previously a member variable of ReplaceSelectionCommand, so it wasn't destroyed
until the undo stack was cleared.
Added a layout test that demonstrates why it is important to get rid of
isProbablyBlock.  The test does a copy/paste of a selection that starts and
ends inside spans with style="display:block".

More information about the webkit-reviews mailing list