[webkit-reviews] review granted: [Bug 6813] elementAtPoint needs to return input element when clicking on new text field : [Attachment 7223] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Mar 21 15:47:28 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6813: elementAtPoint needs to return input element when clicking on new
text field
http://bugzilla.opendarwin.org/show_bug.cgi?id=6813

Attachment 7223: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7223&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
isShadowNode() oughta be const.

_actionInformationForNavigationType should probably pass NO for
allowShadowContent.

Places that check isTextNode and call parentNode might result in nil, and then
you are calling shadowAncestorNode without a nil check.

Looks great.

r=me



More information about the webkit-reviews mailing list