[webkit-reviews] review requested: [Bug 3439] mouseover effects can get stuck sometimes due to missing events : [Attachment 7179] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 19 12:35:33 PST 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 3439: mouseover effects can get stuck sometimes due to missing events

Attachment 7179: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Moved the subframe code from MouseEventWithHitTestResults to a function in

Checking for inDocument() changes the results of one of the included tests to
not match Firefox and WinIE - they seem to dispatch mouseOut events to removed
nodes. OTOH, as mentioned above, it changes the results for IFRAME to match
Firefox. Seems better this way, but I may be missing something.

There is already a ref for targetNode as it is assigned to d->underMouse. But
we actually needed a ref for "this", added now. The difference between
d->underMouse and d->oldUnder looks ugly; I don't really understand it.

Other changes, as discussed on IRC: added a helper for prepareMouseEvent,
removed prevMouseX/prevMouseY, moved the new data members to FrameViewPrivate.

Didn't address the fact that an additional mouse move is needed to mouseOut
events to fire after an element under mouse is removed - will probably fit in
bug 4117 better.

More information about the webkit-reviews mailing list