[webkit-reviews] review denied: [Bug 4855] List item's bullets fail to redraw correctly after their style is set with JavaScript. : [Attachment 7120] Patch

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 4855: List item's bullets fail to redraw correctly after their style is set
with JavaScript.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4855

Attachment 7120: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7120&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
We discussed some options on IRC.  You can't delay the style setting on the
marker, since non-layout changes like foreground color have to propagate
immediately.  You can't rely on setStyle always triggering a layout.

The bug here seems to only be an issue when a future layout is triggered by
setStyle.  In this case the style relies on the layout repaint machinery, but
that machinery is not good enough here.

Possible solutions include:
(1) Destroy the marker when setStyle triggers a layout of the list item.
(2) Repaint the marker when setStyle triggers a layout of the list item.  Could
be checked by asking if selfNeedsLayout after the setStyle of the list item's
base class has been done.