[webkit-reviews] review granted: [Bug 7805] LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod : [Attachment 7114] proposed fix

[bugzilla-request-daemon at opendarwin.org]

Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 7805: LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod
http://bugzilla.opendarwin.org/show_bug.cgi?id=7805

Attachment 7114: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7114&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Nice fix.

I really wish the method/field weren't responsible for deleting this data. What
if a caller wanted to hang on to it past the method's/field's lifetime?

Still, in practice that doesn't seem to happen, and this is the idiom used in
the rest of the bindings code, so I think it's the right fix.