[webkit-reviews] review cancelled: [Bug 7683] Implement execCommand(UnLink) : [Attachment 7103] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Mar 16 02:44:52 PST 2006

Justin Garcia <justin.garcia at apple.com> has cancelled Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 7683: Implement execCommand(UnLink)

Attachment 7103: patch

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
Eek, I forgot to svn add Unlink.{h,cpp}!  Removing the review flag until I
check in a new patch.  Here are some other problems I noticed:

This should be a FIXME
+    // This pushes down anchors even if they are fully selected.  This is 
+    // less efficient, but makes this code much less complicated.

I now use the new form of the ApplyStyleCommand constructor in 3 places:
+    EditCommandPtr cmd(new ApplyStyleCommand(document(), new
+    applyCommandToComposite(cmd);
I should put a convenience method in CompositeEditCommand.

I should follow the style guidelines even in JS code:
+    }
+    else {
+	 execUnlinkCommand();
+    }

All I really care about in the test case is the result of innerHTML, so I
should probably make the test use dumpAsText.

More information about the webkit-reviews mailing list