[webkit-reviews] review denied: [Bug 5476] Dynamically adding <link> for CSS style sheet outside <head> fails to load style sheet : [Attachment 7080] Proposed patch

Thu Mar 16 02:24:43 PST 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 5476: Dynamically adding <link> for CSS style sheet outside <head> fails to
load style sheet
http://bugzilla.opendarwin.org/show_bug.cgi?id=5476

Attachment 7080: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7080&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
It is not an acceptable solution to crawl the entire document looking for
stylesheets.

It is also completely invalid HTML to support <link> outside of the head by the
way (this is in case the developer of the site in question is paying attention
and cares enough to write HTML code that doesn't suck).

I would suggest implementing the same fix that was done for <style> elements,
which are also illegal outside of the head.  Namely you should move the <link>
element inside the head when the error condition is encountered while parsing. 
See htmlparser.cpp line 343 for how we do this for both <title> and <style>.