[webkit-reviews] review requested: [Bug 5393] Anchor links do not jump to ID attributes on table row elements : [Attachment 7102] Patch that gives tables rows and sections correct dimensions.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 15 19:38:51 PST 2006


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 5393: Anchor links do not jump to ID attributes on table row elements
http://bugzilla.opendarwin.org/show_bug.cgi?id=5393

Attachment 7102: Patch that gives tables rows and sections correct dimensions.
http://bugzilla.opendarwin.org/attachment.cgi?id=7102&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch gives table rows and sections correct dimensions.

This creates interesting issues that had to be solved, namely that cells are
not in row coordinate space, but are instead in section coordinate space.  This
meant that various functions that naively crawl up the render tree to adjust
coordinate spaces have to be corrected to not incorrectly add in row offsets
when dealing with cells.

Some other things to note are that RenderTableRows and RenderTableSections
cannot be hit tested.  This matches other browsers.  We had this right before,
since these objects had no dimensions before (RenderTableSection had a height
but a zero width), but now we have to be explicit about excluding them since
they have valid bounding boxes.

Finally, in order to continue to deal with the insanity of borderTopExtra and
borderBottomExtra, I've made whether or not to include borderTopExtra a
required flag on absolutePosition.  This will force anyone who uses this
function to think about what number it is they actually want.  This whole
feature is insane and table cells should someday be reworked simply to have
both outer and inner boxes instead of trying to do both using only one block.



More information about the webkit-reviews mailing list