[webkit-reviews] review requested: [Bug 7761] Tabs in class attribute not treated as whitespace : [Attachment 7089] Revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 15 10:01:28 PST 2006

opendarwin.org at mitzpettel.com has asked  for review:
Bug 7761: Tabs in class attribute not treated as whitespace

Attachment 7089: Revised patch

------- Additional Comments from opendarwin.org at mitzpettel.com
(In reply to comment #3)
> OK, let me now be crazy and make premature optimization comments:

Yay! I followed your suggestions in this version.

> Do we want to optimize the common case [...] so that we
> don't create a new atomic string for that case?

In that case, this patch uses AtomicString(classAttr) instead of
AtomicString(str, length), but I almost convinced myself that there is no

> Not sure what to do about these nitpicks. The code is good as is.

Not really... it was also checking each boundary character twice!

More information about the webkit-reviews mailing list