[webkit-reviews] review granted: [Bug 4171] text-transform:capitalize exhibits incorrect behavior in many edge cases : [Attachment 7069] First attempt at implementing UBreakIterator

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Mar 14 21:44:57 PST 2006


Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 4171: text-transform:capitalize exhibits incorrect behavior in many edge
cases
http://bugzilla.opendarwin.org/show_bug.cgi?id=4171

Attachment 7069: First attempt at implementing UBreakIterator
http://bugzilla.opendarwin.org/attachment.cgi?id=7069&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks great! Reusing the word break iterator like this is good. 

One thing I'm not 100% sure about:

+ QChar previous = 0;

Does the ICU word break iterator handle the case of an initial null character
properly? For example, if you do a document that contains only <span
style="text-transform: capitalize">word</style> properly capitalize the word?
If so, fine to land as is, otherwise I think a space might be a better default
choice.

r=me assuming this case works.



More information about the webkit-reviews mailing list