[webkit-reviews] review requested: [Bug 4171] text-transform:capitalize exhibits incorrect behavior in many edge cases : [Attachment 7069] First attempt at implementing UBreakIterator

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Mar 14 20:19:07 PST 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 4171: text-transform:capitalize exhibits incorrect behavior in many edge
cases
http://bugzilla.opendarwin.org/show_bug.cgi?id=4171

Attachment 7069: First attempt at implementing UBreakIterator
http://bugzilla.opendarwin.org/attachment.cgi?id=7069&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a first pass at implementing text-transform:capitalize with a
UBreakIterator. This fixes a TOT bug I noticed where we were no longer
capitalizing after non-breaking spaces. It also changes some of our current
behavior in ways that I think is good. For example, instead of
"Newcastle-upon-tyne," this patch makes it "Newcastle-Upon-Tyne." Also instead
of "E.g." this new patch writes out "E.G." These new behaviors are not
necessarily correct, but they at least seem consistent and more correct than
the old behavior for these edge cases.

The patch came out very interleaved so it is kind of hard to read.



More information about the webkit-reviews mailing list