[webkit-reviews] review requested: [Bug 7578] TinyMCE: Implement execCommand CreateLink : [Attachment 7066] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Mar 14 16:09:47 PST 2006

Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 7578: TinyMCE: Implement execCommand CreateLink

Attachment 7066: patch

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
Another way to do this would be to pull out the parts of ApplyStyleCommand that
apply style to text runs from the parts that do the setup, traversal and
cleanup, and make two new classes, PushInlineChangeCommand and
ApplyInlineStyleCommand, with CreateLink and ApplyinlineStyleCommand as
subclasses of PushInlineChangeCommand.	That's more risky and probably not
worth the effort unless we think we'll end up needing PushInlineChange in order
to implement something else.

More information about the webkit-reviews mailing list