[webkit-reviews] review granted: [Bug 7765] hasAttribute always
returns false for uppercase attribute names like "STYLE" :
[Attachment 7061] patch with detailed change log and a layout test
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Mar 14 09:58:27 PST 2006
Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 7765: hasAttribute always returns false for uppercase attribute names like
"STYLE"
http://bugzilla.opendarwin.org/show_bug.cgi?id=7765
Attachment 7061: patch with detailed change log and a layout test
http://bugzilla.opendarwin.org/attachment.cgi?id=7061&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
The new layout test "console" is neat.
"Did not raise an exception as expected" sounds ambiguous to me. I would say,
"was expected to raise an exception but didn't" instead.
Am I right that lowercasedName is only actually lower case in the HTML case?
Maybe we should just call it something like nameCopy instead.
r=me
More information about the webkit-reviews
mailing list