[webkit-reviews] review granted: [Bug 7259] Pages in bugzilla
scroll slowly when obsolete attachments are present :
[Attachment 7055] Complete patch.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Mar 14 02:09:05 PST 2006
Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 7259: Pages in bugzilla scroll slowly when obsolete attachments are present
http://bugzilla.opendarwin.org/show_bug.cgi?id=7259
Attachment 7055: Complete patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=7055&action=edit
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me, but I have some style comments:
+ // Always examine the canvas and the root.
+ // FIXME: We need to
Is that the comment you meant to write?
+IntRect RenderLayer::absoluteBoundingBox() const
This function is tricky, it might be easier to read if you broke out the inline
and non-inline cases.
+ result.setX(m_x + result.x());
+ result.setY(m_y + result.y());
I think this would read better using IntRect::move
+ return IntRect(absX + result.x() - m_x,
+ absY + result.y() - m_y,
+ result.width(),
+ result.height());
another case for using move() IMO
More information about the webkit-reviews
mailing list