[webkit-reviews] review denied: [Bug 3439] On slow machines javascript doesn't behave as it should : [Attachment 7051] naive fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Mar 13 14:40:43 PST 2006

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 3439: On slow machines javascript doesn't behave as it should

Attachment 7051: naive fix

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Yeah, you do need a test. And a ChangeLog. DumpRenderTree can simulate mouse
events, so a test is possible.

You can test oldUnder itself for truth instead of oldUnder.get().

Doesn't this patch prevent mouseout from firing when you move the mouse between
frames? In general, what's the purpose of the test

    oldUnder->getDocument() != frame()->document()

? To ensure that the node is still in the document? inDocument() is probably
better for that. (Make sure your test covers that case.)

More information about the webkit-reviews mailing list