[webkit-reviews] review granted: [Bug 7698] Add Scrolling support
for WebKit on Win32 : [Attachment 6984] Implement
ScrollViewWin to add scrolling support and fix invalidation
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Mar 10 07:05:53 PST 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7698: Add Scrolling support for WebKit on Win32
http://bugzilla.opendarwin.org/show_bug.cgi?id=7698
Attachment 6984: Implement ScrollViewWin to add scrolling support and fix
invalidation
http://bugzilla.opendarwin.org/attachment.cgi?id=6984&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ return IntPoint(kMax(docSize.width() - scrollPoint.x(), 0),
kMax(docSize.height() - scrollPoint.y(), 0));
Please don't use "KWQDef.h" and kMax in new code. Instead, include <algorithm>,
do using namespace std, and use plain old "max".
public:
+#if WIN32
+ ScrollView();
+ ~ScrollView();
+#endif
I suggest putting these platform-specific ifdefs at the ends of classes, as I
mentioned the other day in the office.
+#include "IntRect.h"
The file uses IntPoint, but you include IntRect.h here. It would be better to
include IntPoint.h.
Otherwise seems fine, at least for the moment.
r=me
More information about the webkit-reviews
mailing list