[webkit-reviews] review granted: [Bug 7656] Query string always appended to Flash URLs, instead of being replaced : [Attachment 6945] fix with test and ChangeLog

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 8 16:29:38 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7656: Query string always appended to Flash URLs, instead of being replaced
http://bugzilla.opendarwin.org/show_bug.cgi?id=7656

Attachment 6945: fix with test and ChangeLog
http://bugzilla.opendarwin.org/attachment.cgi?id=6945&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     NPUTF8 urlString[size];

You should use malloc here instead of using the gcc extension that allows
variable sized arrays. Maybe strdup is the best way.

But that's in test code.

Looks great, r=me.



More information about the webkit-reviews mailing list