[webkit-reviews] review granted: [Bug 6899] SVG <rect> does not respect display: none : [Attachment 6936] New patch which implements solution 1 as described by maciej

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 8 04:10:03 PST 2006


Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6899: SVG <rect> does not respect display: none
http://bugzilla.opendarwin.org/show_bug.cgi?id=6899

Attachment 6936: New patch which implements solution 1 as described by maciej
http://bugzilla.opendarwin.org/attachment.cgi?id=6936&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This looks fine.  This will need a change log (and the attached test case) when
landing.   We also might consider someday reversing this rule such that all
SVGStyleElementImpls which do not want renders implement rendererIsNeeded and
return false, where all other renders just get the
StyledElementImpl::renderIsNeeded behavior by default.



More information about the webkit-reviews mailing list