[webkit-reviews] review requested: [Bug 7555] :hover style not applied on hover if its display property is different from original style's : [Attachment 6927] Naive patch

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 7555: :hover style not applied on hover if its display property is
different from original style's
http://bugzilla.opendarwin.org/show_bug.cgi?id=7555

Attachment 6927: Naive patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6927&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
As Darin has suggested, I moved the code that sets the
hover/active/inActiveChain bets out of RenderLayer into DocumentImpl. While
doing this, I introduced a couple of possible over-simplifications:

1) The new code walks up the DOM tree directly instead of walking up the render
tree and looking up the corresponding elements. I couldn't figure out the case
where this makes a difference (despite the comment about CSS3 ::outside).

2) The old code had a separate mustBeInActiveChain boolean, theoretically
allowing for nodes not in the active chain to become hovered and active while
an active chain existed. Again, I failed to come up with a case where this
could actually happen (needs a non-readonly NodeInfo with the mouse button down
which is not a mouseMoved and is not the initial mouseDown).

Hyatt wrote the current hover/active code so he's likely to know what cases I
missed.