[webkit-reviews] review denied: [Bug 7619] TimerBase::setNextFireTime removes a timer from the list of firing timers even when not changing its heap position : [Attachment 6888] Fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 5 21:22:01 PST 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7619: TimerBase::setNextFireTime removes a timer from the list of firing
timers even when not changing its heap position
http://bugzilla.opendarwin.org/show_bug.cgi?id=7619

Attachment 6888: Fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6888&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
If the timer is in the timersReadyToFire set and nothing has re-scheduled it to
fire later, then m_nextFireTime is going to be 0, so the only time we won't go
inside the if statement is if newTime is also 0. There's no bug here.



More information about the webkit-reviews mailing list