[webkit-reviews] review granted: [Bug 7582] c_utility.cpp contains
platform dependant code : [Attachment 6886] new patch with
changes and ChangeLog
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Mar 5 21:19:24 PST 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7582: c_utility.cpp contains platform dependant code
http://bugzilla.opendarwin.org/show_bug.cgi?id=7582
Attachment 6886: new patch with changes and ChangeLog
http://bugzilla.opendarwin.org/attachment.cgi?id=6886&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks good, r=me.
We could simplify this by doing the malloc outside either if statement, but
it's good as is.
At some point we should test that ucnv_open is fast enough when used over and
over again like this.
More information about the webkit-reviews
mailing list