[webkit-reviews] review granted: [Bug 7618] use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL) : [Attachment 6880] take 1 (kinda ugly)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 5 20:17:57 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7618: use unsigned bitfields when storing enums in them, to avoid mangling
on win32 (was causing all layout to be RTL)
http://bugzilla.opendarwin.org/show_bug.cgi?id=7618

Attachment 6880: take 1 (kinda ugly)
http://bugzilla.opendarwin.org/attachment.cgi?id=6880&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I didn't spot any problems. The trick with a change like this is to do enough
testing.



More information about the webkit-reviews mailing list