[webkit-reviews] review granted: [Bug 3905] Missing </title> makes page blank : [Attachment 6873] Patch v7

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 5 12:05:35 PST 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 3905: Missing </title> makes page blank

Attachment 6873: Patch v7

------- Additional Comments from Darin Adler <darin at apple.com>
Nice tests!

The part here that seems tricky is knowing how much of the tokenizer state we
need to save and restore. In theory, all the state of both the tokenizer and
the parser might have to be saved.

I'm sure for individual fields we can prove why they don't need to be saved.
But I'm concerned that there are *so* many that we aren't saving and restoring.

Just to pick a couple of example, what about "scriptCodeResync", "pendingSrc",
and "currentPrependingSrc"?

I'm going to mark this review+, but I'm concerned there are some new edge cases
we're introducing here. Maybe more testing is the right thing to do.

More information about the webkit-reviews mailing list