[webkit-reviews] review requested: [Bug 7602] Only use fixupChar for entities : [Attachment 6857] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 5 00:36:05 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7602: Only use fixupChar for entities
http://bugzilla.opendarwin.org/show_bug.cgi?id=7602

Attachment 6857: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6857&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Actually, the Latin-1/windows-1252 quirk is still enforced by
effectiveEncoding(). It is covered by existing test cases, although indirectly,
so adding Maciej's test case will be IMO useful, too. It passes with a single
difference from Firefox - the latter maps 0x81 to U+FFFD, while fixupChar
leaves it at U+0081.

Resetting the r? flag for performance testing...



More information about the webkit-reviews mailing list