[webkit-reviews] review denied: [Bug 4840] Frames only resize wider, can't make them narrower : [Attachment 6833] Don't lose track of the resizing frameset

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Mar 4 11:47:31 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 4840: Frames only resize wider, can't make them narrower

Attachment 6833: Don't lose track of the resizing frameset

------- Additional Comments from Darin Adler <darin at apple.com>
We would like a capturing mechanism that works for all drags. But adding one
specifically for the frameset resizing seems fine for now.

It's not good to add stuff about resizing to the DOM, though. This should stay
in the view system (rendering and FrameView).

+    DocumentImpl *d = getDocument();
+    FrameView *w = d ? d->view() : 0;
+    if (w)
+	 w->setResizingFrameSet(e ? this : 0);

getDocument no longer ever returns 0 -- nodes now reference their document --
so we don't need a nil-check on the document. I'd also like to see the
FrameView* style used instead of FrameView * as per our style guidelines. But
this function should go.

RenderFrameSet::setResizing should handle this directly, calling the FrameView.
You don't need a boolean in the renderer or the DOM element.

Nice fix in hoverTimerFired.

More information about the webkit-reviews mailing list