[webkit-reviews] review granted: [Bug 6890] SVG - invalid polyline
data causes hang : [Attachment 6815] cleaned version of the method
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Mar 3 01:24:16 PST 2006
Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6890: SVG - invalid polyline data causes hang
http://bugzilla.opendarwin.org/show_bug.cgi?id=6890
Attachment 6815: cleaned version of the method
http://bugzilla.opendarwin.org/attachment.cgi?id=6815&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
svgPolyTo(xPos, xPos, segmentNum++);
looks wrong. It should be
svgPolyTo(xPos, yPos, segmentNum++);
I think. Otherwise this looks fine. Please be sure to add the layout tests,
results, and change log when landing.
With that fixed, this is good to land. r=me.
More information about the webkit-reviews
mailing list