[webkit-reviews] review granted: [Bug 7387] Set up new prototype macros and avoid using #if without defined() in JSC : [Attachment 6797] patch to add platform test macros

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 1 19:48:55 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7387: Set up new prototype macros and avoid using #if without defined() in
JSC
http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

Attachment 6797: patch to add platform test macros
http://bugzilla.opendarwin.org/attachment.cgi?id=6797&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#ifndef PLATFORM(WIN_OS)

That should be #if !

Otherwise looks fine. r=me

Please don't land the partial checkout.html change here.



More information about the webkit-reviews mailing list