[webkit-reviews] review requested: [Bug 7059] TinyMCE: Select All + delete sends you Back intsead of deleting : [Attachment 6799] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 1 18:41:36 PST 2006


Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 7059: TinyMCE: Select All + delete sends you Back intsead of deleting
http://bugzilla.opendarwin.org/show_bug.cgi?id=7059

Attachment 6799: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6799&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
In selectFrameElementInParentIfFullySelected, we should only select the frame
in its parent if the frame is in an editable region.  

Also, WebCore wasn't treating mouse events that the eventSender was sending as
distinct events, since they all had the same eventNumber (0).  This was sending
us into different code paths than we get into when a user does mouse clicks. 
So, I added an eventNumber to the eventSender and increment it every time DRT
creates an event.



More information about the webkit-reviews mailing list