[webkit-reviews] review requested: [Bug 7393] XMLHttpRequest responses are never cached : [Attachment 6790] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 7393: XMLHttpRequest responses are never cached
http://bugzilla.opendarwin.org/show_bug.cgi?id=7393

Attachment 6790: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6790&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
OK, my tests show that caching of XMLHttpRequest responses does work properly
(in Safari with current WebKit builds, at least). Just don't add an
If-Modified-Since header manually, and NSURLConnection will take care of the
rest, and will return a 200 response. It returns a cached response if possible,
or issues a conditional request if re-validation is needed.

If this doesn't work for Dashboard widgets, which I haven't checked, then
perhaps Dashboard always forces a reload of the main document, which defeats
caching of subresources and XMLHttpRequests. Dashboard is closed source, so
you'd need to file a bug via <http://bugreport.apple.com>.

I think this comment is stale, the patch just removes it.