[webkit-reviews] review granted: [Bug 3812] XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET : [Attachment 6786] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 3812: XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST
actually do a GET
http://bugzilla.opendarwin.org/show_bug.cgi?id=3812

Attachment 6786: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6786&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Change looks fine as is, but I have three comments:

    1) Is there a test for the change in JSXMLHttpRequest.cpp? That change
looks fine, but I'd like to see a test that was broken before and fixed now.

    2) Since method is now a String you can use equalIgnoringCase rather than
calling lower when comparing the method with head.

    3) I would like the client pointer to be the first parameter to TransferJob
and the method the second parameter, because the client pointer sort of a "back
pointer to the claler" while the rest of the parameters are the specification
of what the job is to do.

The most important of these three is (1), but I think none are a big enough
deal to prevent landing the patch. I'll say r=me.