[webkit-reviews] review denied: [Bug 9431] REGRESSION: Text inputs not responding to keyboard input : [Attachment 9107] Change layer hit testing to return the inner div instead of the input element

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 30 11:19:16 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9431: REGRESSION: Text inputs not responding to keyboard input
http://bugzilla.opendarwin.org/show_bug.cgi?id=9431

Attachment 9107: Change layer hit testing to return the inner div instead of
the input element
http://bugzilla.opendarwin.org/attachment.cgi?id=9107&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The special case of the inputTag seems like a very bad idea; need some kind of
virtual function on Node instead.

But I'd suggest that instead of this change we go into
RenderLayer::hitTestLayer and make either the RenderObject or the Node have a
change to indirect in the code that is about to call setInnerNode and
setInnerNonSharedNode. Maybe a function called "innerNode" or with the word
"hitTest" in it or something like that.



More information about the webkit-reviews mailing list