[webkit-reviews] review requested: [Bug 9660] Clean up WebKit and WebCore's finalize methods (needs clearly defined tear-down) : [Attachment 9100] Cleans up the finalize methods

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 29 23:10:10 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 9660: Clean up WebKit and WebCore's finalize methods (needs clearly defined
tear-down)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9660

Attachment 9100: Cleans up the finalize methods
http://bugzilla.opendarwin.org/attachment.cgi?id=9100&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
I did not find a good way to fix: <rdar://problem/3694061> -[WebHistoryItem
finalize] is incorrect; design change needed

This one proved difficult to remove. This finalize method also seems the least
critical to resolve, it does not cause any major problems to call
_retainIconInDatabase:NO at an unknown time in the future.



More information about the webkit-reviews mailing list