[webkit-reviews] review denied: [Bug 9358] REGRESSION: Assertion
failure in HTMLInputElement::setValueFromRenderer (value ==
constrainValue(value)) when deleting all text : [Attachment
9089] Patch v1 (no changelog; no test)
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Jun 29 08:30:10 PDT 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9358: REGRESSION: Assertion failure in
HTMLInputElement::setValueFromRenderer (value == constrainValue(value)) when
deleting all text
http://bugzilla.opendarwin.org/show_bug.cgi?id=9358
Attachment 9089: Patch v1 (no changelog; no test)
http://bugzilla.opendarwin.org/attachment.cgi?id=9089&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
It's driving me crazy too!
This is an acceptable workaround for the problem, but not the right way to fix
the problem.
I don't want an extra call to constrainValue here in the production code in the
long term.
I'd prefer isEmpty() to length() == 0, and I'd like a comment here that
explains exactly why we need a special case.
Perhaps a better way to do it would be to add code like this before the assert:
// Workaround for bug where trailing \n is included in the result of
textContent.
// <URL of a new bug report>
if (value == "\n")
value = "";
More information about the webkit-reviews
mailing list