[webkit-reviews] review denied: [Bug 8850] cocoa bindings - crash when DOM nodes are deleted while NSTreeController+NSTableView are bound : [Attachment 9080] test case for this bug and minor change to DumpRenderTree to support it

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 29 08:02:53 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8850: cocoa bindings - crash when DOM nodes are deleted while
NSTreeController+NSTableView are bound
http://bugzilla.opendarwin.org/show_bug.cgi?id=8850

Attachment 9080: test case for this bug and minor change to DumpRenderTree to
support it
http://bugzilla.opendarwin.org/attachment.cgi?id=9080&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Test case looks great as does the enhancement of DumpRenderTree, but since you
put these two together but separate from the bug fix I have to review- since we
can't land these until the bug is fixed and if I marked it review+ it would sit
in the "to be checked in" queue.

If you give a patch with just the DumpRenderTree enhancements I could review+
that.

Or you could put this test case along with the bug fix and when it's all ready
to go we can land the whole thing atomically, and so we'd review atomically
too.



More information about the webkit-reviews mailing list