[webkit-reviews] review denied: [Bug 9618] Pasting a table can
cause content after the table to be absorbed into the table :
[Attachment 9075] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Jun 28 12:36:46 PDT 2006
Justin Garcia <justin.garcia at apple.com> has denied Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 9618: Pasting a table can cause content after the table to be absorbed into
the table
http://bugzilla.opendarwin.org/show_bug.cgi?id=9618
Attachment 9075: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9075&action=edit
------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
I'd rather you to change the bool recorded in ReplacementFragment's node ->
RenderingInfo HashMap to 'isBlockFlow || isTable'. And rename the bool to
'isBlockOrTable'. That's a more complete fix.
Also, in your testcase you don't need to log innerHTML, the fix will be
reflected in the dumped render tree.
Also I like it when an editing testcase sets an exact selection up front,
instead of setting it using moves/extends. That keeps the test from including
superfluous editing delegate notifications (which are notoriously hard to read
through).
These last to points are optional suggestions.
More information about the webkit-reviews
mailing list