[webkit-reviews] review denied: [Bug 9605] REGRESSION: pageX and
pageY are both 0 for events created with initMouseEvent :
[Attachment 9066] Improved patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Jun 27 13:43:13 PDT 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9605: REGRESSION: pageX and pageY are both 0 for events created with
initMouseEvent
http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
Attachment 9066: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9066&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I think it's pretty ugly to have two different initCoordinates functions, but I
think this will work right.
Ultimately we could change this all so that pageX/Y is always computed from
clientX/Y. The only reason it's not like that today is Macintosh-specific
stuff: the "viewport" coordinates for the web view are actually window
coordinates on OS X so they can't be used directly for clientX/Y. Otherwise,
we'd go change all the callers to pass in clientX/Y and the code would all
match. It would be great to straighten that out some day.
Patch needs to include the patch to the test results too, though.
r=me, but review- because we need a patch that includes
fast/dom/window-xy-properties-expected.txt.
More information about the webkit-reviews
mailing list