[webkit-reviews] review granted: [Bug 9617] wx port compile fixes :
[Attachment 9056] wx port compilation fixes and updates
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Jun 27 09:46:10 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9617: wx port compile fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=9617
Attachment 9056: wx port compilation fixes and updates
http://bugzilla.opendarwin.org/attachment.cgi?id=9056&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Most of this patch looks great.
But the ImageDocument.cpp change isn't right. There should not be Objective-C++
code in ImageDocument.cpp -- that code should be moved to a separate .mm file.
I'm going to review+ this, but someone needs to change that ImageDocument.cpp
code! Anders?
More information about the webkit-reviews
mailing list