[webkit-reviews] review requested: [Bug 9538] Add support syntax-highlighted HTML source viewing : [Attachment 9053] Patch that gets basic highlighting working.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jun 26 14:41:58 PDT 2006


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 9538: Add support syntax-highlighted HTML source viewing
http://bugzilla.opendarwin.org/show_bug.cgi?id=9538

Attachment 9053: Patch that gets basic highlighting working.
http://bugzilla.opendarwin.org/attachment.cgi?id=9053&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch gets basic highlighting working.  There are still many open issues,
but this is a good first cut to land.

Open issues include:
(1) Loss of the whitespace in between tags and attributes and between attribute
names/values.
(2) Entities need to be preserved.
(3) Scripts and styles don't work.
(4) Comments need to be preserved (this should just be done always).
(5) The DOCTYPE is lost.
(6) The bogus "/" attribute for faux XHTML has to be sent through in view
source mode and treated like it's part of a tag.

... and there are probably numerous other issues...



More information about the webkit-reviews mailing list