[webkit-reviews] review requested: [Bug 8707] event.clientX and event.clientY should be relative to the viewport, not the canvas : [Attachment 9041] Code cleanup

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jun 26 01:28:24 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 8707: event.clientX and event.clientY should be relative to the viewport,
not the canvas
http://bugzilla.opendarwin.org/show_bug.cgi?id=8707

Attachment 9041: Code cleanup
http://bugzilla.opendarwin.org/attachment.cgi?id=9041&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
I know the previous patch landed, however as Darin pointed out calculating the
clientX/clientY in three places is a waste. This patch calculates it in one
place and is
, I feel, cleaner. The results are the same as before.
Also, I think it needs to be checked whether fast/events/objc-event-api.html
regressed
due to the previous patch.
Cheers,

Rob.



More information about the webkit-reviews mailing list