[webkit-reviews] review granted: [Bug 9571] Teach svn-apply and
svn-unapply to handle directory adds and removes better :
[Attachment 9013] Patch v1
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Jun 25 10:07:00 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9571: Teach svn-apply and svn-unapply to handle directory adds and removes
better
http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
Attachment 9013: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=9013&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ if (exists $removeDirectoryIgnoreList{$_}) {
+ 0;
+ }
+ elsif (! -d File::Spec->catdir($dir, $_)) {
+ 1;
+ }
+ else {
Our formatting would be:
} elsif
not
}
elsif
I'm not sure that svn revert is the right thing to do in svn-unapply, but I
can't think of any other way to bring the file back. Ideally the file would
come back with the contents from the patch rather than the current contents in
Subversion?
r=me
More information about the webkit-reviews
mailing list