[webkit-reviews] review requested: [Bug 9571] Teach svn-apply and svn-unapply to handle directory adds and removes better : [Attachment 9013] Patch v1

[bugzilla-request-daemon at opendarwin.org]

David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked  for review:
Bug 9571: Teach svn-apply and svn-unapply to handle directory adds and removes
better
http://bugzilla.opendarwin.org/show_bug.cgi?id=9571

Attachment 9013: Patch v1
http://bugzilla.opendarwin.org/attachment.cgi?id=9013&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Changes to svn-apply:

- Sorted subroutines alphabetically; handleBinaryChange() moved but did not
change; addDirectoriesIfNeeded() was moved and had major changes.
- Changed addDirectoriesIfNeeded() subroutine to operation without changing
directories.  Keep track of directories checked for adding in
%checkedDirectories global.  Removed $startDir global variable.
- Extracted svnStatus() subroutine from existing code.
- Added removeDirectoriesIfNeeded() subroutine to check for empty directories. 
It is called after all patches have been applied.
- Added isDirectoryEmptyForRemoval() subroutine used by
removeDirectoriesIfNeeded() to determine if a directory is empty or not.  This
sub uses the %removeDirectoryIgnoreList global to filter out directories to
ignore when checking if a given directory is empty.  Note that "return" can't
be used in the grep{} code block, otherwise that will cause the entire function
to return.

Changes to svn-unapply:

- Sorted subroutines alphabetically; unapplyPatch() was moved but did not
change.
- Extracted svnStatus() subroutine from existing code.
- Removed unused $startDir global variable.
- Added revertDirectories() subroutine.  Uses %directoriesToCheck global
variable when running.	This variable is set as patches are unapplied.