[webkit-reviews] review requested: [Bug 8707] event.clientX and event.clientY should be relative to the viewport, not the canvas : [Attachment 9010] Improved patch+testcase

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 24 14:49:18 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 8707: event.clientX and event.clientY should be relative to the viewport,
not the canvas
http://bugzilla.opendarwin.org/show_bug.cgi?id=8707

Attachment 9010: Improved patch+testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=9010&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
Hi Darin,

This should address most of your points. About the wheel event, I tried to
include
code into DumpRenderTree to generate wheel events, much like mouse events.
However
I could not find a suitable NSEvent method to create them! So I think the
solution is for
someone to indicate to me what I do wrong or generate them some other way, or
opt
for a manual test for the wheel events?
Cheers,

Rob.



More information about the webkit-reviews mailing list