[webkit-reviews] review denied: [Bug 7204] float inserted in fixed height block via DOM not repainted : [Attachment 8865] Repaint all floating descendants when moving during layout

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 7204: float inserted in fixed height block via DOM not repainted
http://bugzilla.opendarwin.org/show_bug.cgi?id=7204

Attachment 8865: Repaint all floating descendants when moving during layout
http://bugzilla.opendarwin.org/attachment.cgi?id=8865&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'm not convinced on this one quite yet.  When a float moves during layout, it
should still get its coordinates changed in the floating objects list of the
block that will ultimately paint it.

What bothers me about this patch is that it will end up repainting the same
float over and over when you have a bunch of nested blocks that all have the
same float in their floatingObjects list.

I also don't quite understand your point about repaintAfterLayout vs.
repaintDuringLayout since the former uses getAbsoluteRepaintRectIncludingFloats
(which also has the !noPaint check).

Also for a check like this:

+	     if (paintAll || !r->noPaint && !r->node->layer()) {	       


You'll do a repaint even of something with a layer, and that's not necessary
(since layers handle repainting themselves properly already... make the same
test case with position:relative on the float and you'll see it work I bet).