[webkit-reviews] review granted: [Bug 9547] Resize corner does not
track the mouse accurately : [Attachment 8977] Proposed fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Jun 23 21:29:50 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9547: Resize corner does not track the mouse accurately
http://bugzilla.opendarwin.org/show_bug.cgi?id=9547
Attachment 8977: Proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=8977&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
An offset should be an IntSize, not an IntPoint.
If this was an IntSize, then this:
+ currentPoint.move(offsetFromResizeCorner.x(), offsetFromResizeCorner.y());
would be:
currentPoint += offsetFromResizeCorner;
This otherwise looks good to me. I think I'm going to mark it review+ -- if you
decide to do a new patch with IntSize, then you can clear the review flag on
this one.
More information about the webkit-reviews
mailing list