[webkit-reviews] review requested: [Bug 9532] date setUTCFullYear to setUTCMinutes adding 1 hour in time zone 0 : [Attachment 8988] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 23 13:26:36 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 9532: date setUTCFullYear to setUTCMinutes adding 1 hour in time zone 0
http://bugzilla.opendarwin.org/show_bug.cgi?id=9532

Attachment 8988: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=8988&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
To me it seems related to BST handling in 1970(which is default for t3):

http://en.wikipedia.org/wiki/British_Summer_Time

Now this is not a problem in itself, but the tm structure seems to indicate
summer time, even
at 1-1-1970! I guess that is correct given the wikipedia page, but it is not
helping our calculation.
One way I found to fix it is to just use the current time, assuming that from
now on we stick to winter
and summertime as we know it since years. I am welcome to input on how to test
and suggestions
for better, or likely more efficient fixes. One way could be to single out the
BST case?
Cheers,

Rob.



More information about the webkit-reviews mailing list