[webkit-reviews] review denied: [Bug 9215] events go to infinite loop if bubbled : [Attachment 8936] patch for fixing the bug

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 22 12:44:00 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9215: events go to infinite loop if bubbled

Attachment 8936: patch for fixing the bug

------- Additional Comments from Darin Adler <darin at apple.com>
This patch won't work, because it's got DOM:: and Undefined() in it. Those are
long-renaemed things that don't exist in our current tip of tree.

It's also not formatted based on the style guildlines.

In addition, I don't think this fix is correct. It checks for one of the many
different ways an infiite loop could happen, and it could prevent legitimate
code that loops once from working. There are all sorts of other similar
infinite loops that this code change would not prevent, for example, one
involving two different events that each dispatched the other.

What we need to diagnose this is a test page that works in other browsers and
fails in WebKit so we can figure out what behavior is wrong. I'm absolutely
certain this isn't it.

Infinite loops can happen, and the way to handle that is to allow you to
interrupt the script.

More information about the webkit-reviews mailing list