[webkit-reviews] review denied: [Bug 9467] TreeWalker/NodeIterator do not restrict the traversal : [Attachment 8966] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 22 09:33:54 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 9467: TreeWalker/NodeIterator do not restrict the traversal

Attachment 8966: patch

------- Additional Comments from Darin Adler <darin at apple.com>
Seems low risk to make an incremental improvement to these classes since they
are broken in major ways.

But I do not understand the need for changes to Node.cpp. Before I can review+
this I need to understand why that file had to change at all. And in fact,
those functions are used heavily all over the code, so changes to them are high
risk and need a motivation.

And we need a change log entry too.

More information about the webkit-reviews mailing list